Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve some issues with reopening full screen windows #5280

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xfaris
Copy link

@xfaris xfaris commented Nov 21, 2024

Description:

Resolve the issue of incorrect position when opening a full screen window after it is hidden.
Resolve the issue of flickering when the mouse is placed on the taskbar when the full screen window is hidden and opened again.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Resolve the issue of incorrect position when opening a full screen window after it is hidden.
Resolve the issue of flickering when the mouse is placed on the taskbar when the full screen window is hidden and opened again.
@xfaris xfaris marked this pull request as draft November 21, 2024 09:08
@xfaris xfaris marked this pull request as ready for review November 21, 2024 09:09
@Jacalz
Copy link
Member

Jacalz commented Nov 21, 2024

If the issue is a result of a reach condition then we should solve the race condition instead of sleeping and re-running a function. If we are certain that it is not, we should document clearly why we do it and which issue it relates to.

Do you have an issue number for this problem?

@andydotxyz
Copy link
Member

If the issue is a result of a reach condition then we should solve the race condition instead of sleeping and re-running a function. If we are certain that it is not, we should document clearly why we do it and which issue it relates to.

I think they just copied the code from the initial show function.
Perhaps factoring that out into a function called from both places would be clearer?

@coveralls
Copy link

Coverage Status

coverage: 59.995% (+0.02%) from 59.98%
when pulling ebf7427 on xfaris:develop
into b529a32 on fyne-io:develop.

@Jacalz
Copy link
Member

Jacalz commented Nov 27, 2024

I think they just copied the code from the initial show function.
Perhaps factoring that out into a function called from both places would be clearer?

I'm just generally sceptical about creating a new goroutine and then sleeping. How do we know that the arbitrary sleep time is the right one? Why do we even have to spawn a goroutine and then do the operation at a later time? Seems to me like we are either working around a bug or some strange race condition.

Excuse my ramblings though. If this is the only way to solve the problem then sure, a common function with an explanatory comment would be much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants