Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance of file dialog scrolling in large folders #5285

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

andydotxyz
Copy link
Member

Some new changes but also removing a threading change on image - it has caused a few performance issues and in 2.6 we will go in a different direction anyhow.

Fixes #4307

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

The reason was thread related and we are about to move from that problem anyway.
Reverts fyne-io@4efaa1b
@coveralls
Copy link

Coverage Status

coverage: 60.021% (+0.04%) from 59.983%
when pulling 12c9db9 on andydotxyz:fix/4307
into 8b4e391 on fyne-io:develop.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is always nice when the fix involves removing stuff. Well done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants