Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure text and SVG textures re-rasterize when window is dragged to new monitor #5335

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Ensure text and SVG textures re-rasterize when window is dragged to new monitor #5335

merged 2 commits into from
Dec 23, 2024

Conversation

dweymouth
Copy link
Contributor

Description:

A regression in 2.5.3 resulted in text and SVG rasterizations not re-rasterizing when the window was moved between monitors, resulting in blurriness if the window went from low DPI to high DPI.

Fixes #5323

Checklist:

  • Tests included. -- Tested manually
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Dec 21, 2024 •
edited
Loading

Coverage Status

coverage: 59.649% (-0.001%) from 59.65%
when pulling 91a524f on dweymouth:fix-5323
into 0afa6a9 on fyne-io:develop.

Jacalz
Jacalz reviewed Dec 22, 2024
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't quite comment on the approach but I left a minor comment inline.

internal/driver/glfw/window_wasm.go Outdated Show resolved Hide resolved
andydotxyz
andydotxyz approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this oversight

@dweymouth dweymouth merged commit 03a3827 into fyne-io:develop Dec 23, 2024
12 checks passed
@dweymouth dweymouth deleted the fix-5323 branch December 23, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz left review comments

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dweymouth @coveralls @andydotxyz @Jacalz