Add new canvas.RecolorSVG API #5345
Conversation
internal/svg/svg.go
Outdated
| return content, err | ||
| } | ||
|
|
||
| func colorizeImpl(src []byte, clr color.Color, errFn func(string, error)) []byte { |
There was a problem hiding this comment.
This error function seems a bit strange in my opinion. Why not just use the return value of the function directly and call fyne.LogError or similar on that?
There was a problem hiding this comment.
Yeah now that I look at it again, it is a bit strange. It was to minimize both code changes and duplicated code. Fyne.LogError takes 2 arguments, so I guess the alternative is for the signature to be func colorizeImpl(src []byte, clr color.Color) ([]byte, string, error) so that the actual error and the context we add to it can still be passed separately to fyne.LogError. What do you think?
There was a problem hiding this comment.
Do you even need the extra string information? It just seems unintuitive from how Go error handling usually is made? We can lose a bit in the FyneLog error and add any necessary additional information in the error text?
dweymouth
changed the title
Description:
Fixes #4815
Checklist:
Where applicable: