Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One big last lock cleanup #5420

Merged
merged 11 commits into from
Jan 16, 2025
Merged

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Jan 16, 2025

Description:

This removes most of the unnecessary atomic types everything except for app, bindings and so on. It also fixes various small races and cleans up some code leftovers. Maps are still concurrency safe as anyone relying on goroutines might see crashes otherwise.

For #4654

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@Jacalz

This comment was marked as outdated.

@Jacalz Jacalz force-pushed the last-big-lock.cleanup branch from b8c7bc7 to 031e02e Compare January 16, 2025 16:33
@Jacalz
Copy link
Member Author

Jacalz commented Jan 16, 2025

I backed out all changes to maps. It causes crashes for anyone updating widgets outside of the correct threads.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially seeming unrelated things, but it can be hard to know where race work leads!
But thanks for all the tidyup.

@Jacalz Jacalz merged commit 5a4731e into fyne-io:develop Jan 16, 2025
12 checks passed
@Jacalz Jacalz deleted the last-big-lock.cleanup branch January 16, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants