Fix ldflags in GOFLAGS not being respected.

[williambrode]

extractLdflagsFromGoFlags() was not reentrant, but we were calling it a second time when building on windows. PackageWindows does another build and the second one saw an environment with the ldflags stripped out.

This doesn't work before the change (version was not set) but it work after this change.

$Env:GOFLAGS="-ldflags=-X=path/to/pkg/config.Version=v0.0.2"
fyne package -os windows -name myapp.exe -icon ./Icon.png -appBuild 1 -appVersion 1.0.0 -appID com.example.app -tags windows

[Jacalz]

Sorry for this not getting a review. I must admit that I don't quite understand what the code is trying to do or what it fixes but I hope Cedric might understand the inner workings of this tool better.

[williambrode]

I'll try to restate the problem in case it helps. The issue is this code:

	if goFlags != "" {
		os.Setenv("GOFLAGS", goFlags)
	} else {
		os.Unsetenv("GOFLAGS")
	}

This CHANGES the environment - which is obviously global. If this code ever runs a second time (which it does) then it doesn't work because the environment was changed by the first run.

[kpauljoseph]

extractLdflagsFromGoFlags() was not reentrant, but we were calling it a second time when building on windows. PackageWindows does another build and the second one saw an environment with the ldflags stripped out.

This doesn't work before the change (version was not set) but it work after this change.

$Env:GOFLAGS="-ldflags=-X=path/to/pkg/config.Version=v0.0.2"
fyne package -os windows -name myapp.exe -icon ./Icon.png -appBuild 1 -appVersion 1.0.0 -appID com.example.app -tags windows

@williambrode
By it not working, do you mean it is getting compiled but the version doesn't show up?
I have the same issue. After a lot of trial and error, I was able to get it compiled with fyne-cross but the ldflags for windows just wouldn't show up in the final package. I mainly wanted it for versioning, but for now, I've moved onto a generated version file at build time.

If it helps, this is the command that eventually got it compiled successfully, but it the values don't show up in the windows app.

fyne-cross windows \
    -arch=amd64,arm64 \
    -icon ./assets/icons/icon.ico \
    -ldflags=-X=github.com/kpauljoseph/notesankify/pkg/version.Version=test-v0.1.0-dirty,-X=github.com/kpauljoseph/notesankify/pkg/version.CommitSHA=edf25ee,-X=github.com/kpauljoseph/notesankify/pkg/version.BuildTime=2025-01-01-17:56:16 \
    -name "NotesAnkify" \
    -app-id "com.notesankify.app" \
    -output "NotesAnkify" \
    cmd/gui

[andydotxyz]

Like Jacob I think this makes sense, but wonder if @Bluebugs is able to comment as this is an area he has battled before.