Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge latest changes from develop #24

Merged
merged 53 commits into from
Jan 12, 2025
Merged

Merge latest changes from develop #24

merged 53 commits into from
Jan 12, 2025

Conversation

sdassow
Copy link
Contributor

@sdassow sdassow commented Jan 12, 2025

Been a while and was harder than expected.

sdassow added 30 commits January 12, 2025 15:23
@sdassow
WIP: command to scan for new translation
b1847d0
@sdassow
Add flag for dry-run and to update existing translations, clean up an…
3d6da52 
…d document, make verbose mode more useful, and split into smaller pieces
@sdassow
Move options into separate structure to cut dependency
c8949b8
@sdassow
Add simple end to end test
33b5a45
@sdassow
Clean up comments and improve documentation based on feedback
9b24cdc
@sdassow
Add a few more tests
bb09292
@sdassow
Add tests for remaining functions
339bdf8
@sdassow
Change test values to make them easier to distinguish
80b55a9
@sdassow
Use github.com/natefinch/atomic to make file renaming on windows work
81ef851
@sdassow
Write twice to cover non-existing and existing case
67fe3e9
@sdassow
Move defer into the corresponding scope
fe339e1
@sdassow
Check for more errors and add missing defer in tests
df5cd94
@sdassow
Oops, unbreak
dcfc447
@sdassow
Add another missing defer
4cd7a2e
@sdassow
Stop changing default file permissions as it affects portability
1cd728b
@sdassow
Close file directly after read
c021acc
@sdassow
Close file directly after read
783dafa
@sdassow
Ensure tests use the right paths
1ed35cf
@sdassow
Oops, chdir made everything weird, so stop doing that
b34e725
@sdassow
Make options the last argument as done elsewhere
98a5495
@sdassow
Document version near main entry point for the command
0d812ae
@sdassow
Use base (BSD) tar (flags and file extension) on OpenBSD to create pa…
892cfbf 
…ckage
@sdassow
Verify file name
e2b4002
@sdassow
Ignore non-existing files when searching
b6f6d47
@sdassow
Explicitely create directory in each test function
a440d9d
@sdassow
Add function to handle finding sources with some tests
03fc78e
@sdassow
Remove source directory option and allow files and directories as arg…
f6f53d0 
…uments instead, and improve wording in command description
@sdassow
Switch to four spaces like the current translation tool
853d3bb
@sdassow
Remove translationsFile flag and make it a mandatory argument instead…
8ae4a41 
… to avoid dealing with file name and location
@sdassow
Fix test after change
8e5e10a
sdassow and others added 23 commits January 12, 2025 15:23
@sdassow
Show exact result when test fails
2851b23
@sdassow
Use filepath to be more portable
21689d4
@sdassow
Make sure the first argument has the right file extension to prevent …
a6d2095 
…confusing errors when accidentally using it on other files
@sdassow
Check target os to change tar flags
a49d7dc
@sdassow
Sort flags alphabetically
5c52ea4
@sdassow
Add support for optionally scanning for translations in imports
ba44a34
@sdassow
Unbreak after cleanup
5c94538
@sdassow
Don't trip over empty files
41356d9
@sdassow
Look up available languages in source directory to provide to macOS a…
385be95 
…pp language selection
@sdassow
Put languages into FyneApp.toml instead
96ef4a5
@sdassow
Remove test again
abe9803
@sdassow
Make sure to pass underscore as separator
3421380
@sdassow
Remove temporary file that accidentally slipped in
980135a
@sdassow
Remove dry-run flag
b12596f
@Jacalz @sdassow
Use "any" instead of "interface{}"
33dcd7b 
Code style change. I switched all uses over when we migrated to Go
1.19 as base but a few uses of the old name have slipped through
since then. Change them to "any".
@andydotxyz @sdassow
Make sure that bundled icons are no larger than they need to be
73d1600 
Helps to keep app size down too.
Fixes #5272
@andydotxyz @sdassow
Also fix a typo
53d5044
@deining @sdassow
Fix typos
ec3697c
@andydotxyz @sdassow
Correct develop version lookup
6bcdb07
@sdassow
Add new dependency
26e9191
@andydotxyz @sdassow
Make sure that bundled icons are no larger than they need to be
1271cda 
Helps to keep app size down too.
Fixes #5272
@andydotxyz @sdassow
Add basic icon cache test
dca8e89
@sdassow
Put languages into FyneApp.toml instead
ca421dd
@sdassow sdassow mentioned this pull request Jan 12, 2025
Open
andydotxyz
andydotxyz approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks for pulling this together

@sdassow sdassow merged commit b476d10 into main Jan 12, 2025
14 checks passed
@sdassow sdassow self-assigned this Jan 12, 2025
@andydotxyz andydotxyz deleted the sdassow/merge-develop branch January 12, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees

@sdassow sdassow

Labels
None yet
Projects
Migrate cmd/fyne to tools repository
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdassow @andydotxyz @Jacalz @deining