Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The add-on currently does not support to pass the i18n instance via HOC, without any decorator workarounds.
There are 4 ways to integrate
react-i18next
into components mentioned in the quick-start ofreact-i18next
.Suppose I have a component as the following one,
And here is my
preview.js
,There will be a TypeError on rendering MyComp, which is arguing that
TypeError: t1 is not a function
.To work around this error with the current version of the add-on, i.e. v1.3.0, the following decorator should be added.
In this work around,
withTranslation
is used to generate i18n props, i.e.t
,tReady
andi18n
, and an anonymous FC takes those props, injects them intocontext.args
, and invoke the Story rendering.In this pull request, I made the workAround decorator integrated into the add-on directly. Please take a review on this PR and let me know it if there is any concerns or problems.
Thank you for the nice add-on.