Fixed Haskell issues. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aravindgopall
commented
Jan 17, 2024
aravindgopall
commented
- Moved the code to respective tree sitter file
- Fixed signature and function separate nodes by merging
- Fixed pattern match based function separate nodes by merging.
aravindgopall
force-pushed
the
fix/haskell
branch
from
3af3d70 to
2d77b93
Compare
Open
|
Great work! Will have a closer look at this asap! |
|
@fynnfluegge Any suggestions/blockers on this PR. Post this I can raise PR to codeqai also. |
|
@aravindgopall Hey, no blocker imo, had a short look and looks really good! Just wanted to test it locally but had no time yet, but will do it today 🙏 Feel free to raise it there also, really appreciate this! |
fynnfluegge
requested changes
Jan 18, 2024
fynnfluegge
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.