-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add favorite button #3
base: main
Are you sure you want to change the base?
Conversation
liserezvee
commented
Jul 15, 2021
- added favorite button for the favorite cart
@@ -23,12 +35,30 @@ export const SingleProductComponent = ({ | |||
className="px-3 py-2 bg-indigo-200 text-gray-800" | |||
onClick={(e) => { | |||
e.preventDefault(); | |||
onAddToCartClick(product); | |||
onAddToCartClick(product); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit weird 1 space extra indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry i didn't notice those error..
setClick(!click); | ||
}} | ||
> | ||
{!!click ? "Remove Favorite❌" : "Add favorite 👍🏼"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
@@ -5,4 +5,8 @@ db.version(1).stores({ | |||
cartItems: `name, price, description, image, count`, | |||
}); | |||
|
|||
db.version(2).stores({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why create a different db for this, you could just add favoriteItems
store in the previous definition along with cartItems, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought i need another db for this favorite item list . So i used this one.
@@ -0,0 +1,60 @@ | |||
import { useState, useEffect } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not bad but this is pretty much a copy of everything I wrote which is why you have a bunch of code that doesn't quite apply to favorite list. can you identify those lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually i didn't understand how to implement those things so copied your cart item theme and tried to work on this . And i removed lots of cart item codes but as you said there are still available i'll check those codes and try to solve ..
Thanks