Introduce framework for various link strategies #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add some wiring and framework to support various link strategies (unsure how pthonic I am being...) - Moved things to a new elf.py file - Added a new CLI optional argument to select strategy (native vs. virtual)
fzakaria
commented
Dec 24, 2021
| class NativeLinkStrategy(LinkStrategy): | ||
| """Uses the native interpreter in the binary to determine the linking""" | ||
|
|
||
| def explore(self, binary: lief.Binary, filename: str) -> Dict[str, str]: |
There was a problem hiding this comment.
kind of annoying that the binary doesn't give the original filename and just the name portion :/
Could move a bunch of the lief usage into an ELF friendly class maybe in the future.
Add a native strategy similar to that of `libtree`. There are some gaps at the moment such as skipping libc.
When the NEEDED is updated to be absolute, the VERNEEDED (whatever that is) needs to be updated as well for glibc otherwise they do not resolve
fzakaria
commented
Jan 1, 2022
Comment on lines
+44
to
+50
| # we need to update the VERNEED entries now to match | ||
| verneeded = binary.symbols_version_requirement | ||
| for verneed in verneeded: | ||
| if verneed.name in resolution: | ||
| # we want to map the possible shortname soname | ||
| # to the absolute one we generate | ||
| verneed.name = resolution.get(verneed.name) |
There was a problem hiding this comment.
@trws lief makes this very easy although finding that I had to this was not ;)
Comment on lines
+39
to
+42
| # TODO: Figure out why `--list` and `ldd` produce different outcomes | ||
| # specifically for the interpreter. | ||
| # https://gist.github.com/fzakaria/3dc42a039401598d8e0fdbc57f5e7eae | ||
| for line in resolution: |
There was a problem hiding this comment.
@trws let me know if you have some knowledge here of this.
There was a problem hiding this comment.
That's a new one on me. Maybe the loader just prints itself instead of looking it up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(unsure how pythonic I am being...)
virtual)