Merge pull request #1843 from wimg/php74compat-curly-braces

Curly braces for arrays is deprecated in PHP 7.4
fzaninotto · Nov 23, 2019 · c981c04 · c981c04
2 parents a959610 + 1bf4438
commit c981c04
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/Faker/Calculator/Luhn.php b/src/Faker/Calculator/Luhn.php
@@ -24,10 +24,10 @@ private static function checksum($number)
         $length = strlen($number);
         $sum = 0;
         for ($i = $length - 1; $i >= 0; $i -= 2) {
-            $sum += $number{$i};
+            $sum += $number[$i];
         }
         for ($i = $length - 2; $i >= 0; $i -= 2) {
-            $sum += array_sum(str_split($number{$i} * 2));
+            $sum += array_sum(str_split($number[$i] * 2));
         }
 
         return $sum % 10;

diff --git a/test/Faker/Provider/fi_FI/PersonTest.php b/test/Faker/Provider/fi_FI/PersonTest.php
@@ -71,12 +71,12 @@ public function testPersonalIdentityNumberGeneratesCompliantNumbers()
     public function testPersonalIdentityNumberGeneratesOddValuesForMales()
     {
         $pin = $this->faker->personalIdentityNumber(null, 'male');
-        $this->assertEquals(1, $pin{9} % 2);
+        $this->assertEquals(1, $pin[9] % 2);
     }
 
     public function testPersonalIdentityNumberGeneratesEvenValuesForFemales()
     {
         $pin = $this->faker->personalIdentityNumber(null, 'female');
-        $this->assertEquals(0, $pin{9} % 2);
+        $this->assertEquals(0, $pin[9] % 2);
     }
 }
diff --git a/test/Faker/Provider/sv_SE/PersonTest.php b/test/Faker/Provider/sv_SE/PersonTest.php
@@ -50,12 +50,12 @@ public function testPersonalIdentityNumberGeneratesLuhnCompliantNumbers()
     public function testPersonalIdentityNumberGeneratesOddValuesForMales()
     {
         $pin = $this->faker->personalIdentityNumber(null, 'male');
-        $this->assertEquals(1, $pin{9} % 2);
+        $this->assertEquals(1, $pin[9] % 2);
     }
 
     public function testPersonalIdentityNumberGeneratesEvenValuesForFemales()
     {
         $pin = $this->faker->personalIdentityNumber(null, 'female');
-        $this->assertEquals(0, $pin{9} % 2);
+        $this->assertEquals(0, $pin[9] % 2);
     }
 }