Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Phpunit tests fails on 64-bit systems #982

Closed
Powerhead13 opened this issue Jul 28, 2016 · 2 comments
Closed

Phpunit tests fails on 64-bit systems #982

Powerhead13 opened this issue Jul 28, 2016 · 2 comments

Comments

@Powerhead13
Copy link
Contributor

I'm seeing 2 tests fails on Win 10 64 bit.
This definitely happens because of PHP integer overload on 64 bit systems.
This can be fixed by adding quotes to dataprovider values in LuhnTest to convert em to a strings.
Especially, values 561059108101825and 601100099013942

There were 2 failures:

1) Faker\Test\Calculator\LuhnTest::testComputeCheckDigit with data set #9 (561059108101825, '0')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'0'
+'7'

E:\Projects\faker-fork\test\Faker\Calculator\LuhnTest.php:34

2) Faker\Test\Calculator\LuhnTest::testComputeCheckDigit with data set #10 (601100099013942, '4')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'4'
+'3'
@Powerhead13
Copy link
Contributor Author

I created PR to fix that #983

fzaninotto added a commit that referenced this issue Sep 7, 2016
Fix phpunit tests fail on 64-bit systems #982
@fzaninotto
Copy link
Owner

Fixed by #983

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants