Generate valid individual identification numbers kk_KZ

[YerlenZhubangaliyev]

'individualIdentificationNumber' method now generates valid individual identification numbers

[ankitpokhrel]

You can flip conditions and remove &&

if ($year >= 2000 && $year <= DateTime::year()) {
    return self::CENTURY_21ST;
} elseif ($year >= 1900) {
    return self::CENTURY_20TH;
} elseif ($year >= 1800) {
    return self::CENTURY_19TH;
}

[ankitpokhrel]

@return integer|null

[fzaninotto]

never, ever use rand in Faker. See explanation in https://github.com/fzaninotto/Faker/blob/master/CONTRIBUTING.md

[YerlenZhubangaliyev]

done

[fzaninotto]

don't duplicate the checksum code here. Instead, refactor it into a utility function, and use it both in the generator and in the test.

[YerlenZhubangaliyev]

done

[ankitpokhrel]

Haven't tested, but looks like your methods can be refactored like this:

public static function individualIdentificationNumber(\DateTime $birthDate = null, $gender = self::GENDER_MALE)
{
    if (!$birthDate) {
        $birthDate = DateTime::dateTimeBetween();
    }

    $population = mt_rand(1000, 2000);
    $century    = self::getCenturyByYear((int) $birthDate->format('Y'));
    
    $iin  = $birthDate->format('ymd');
    $iin .= (string) self::$genderCenturyMap[$gender][$century];
    $iin .= (string) $population;

    return  $iin . (string) self::checkSum($iin);
}

/**
 * @param string $iinValue
 *
 * @return integer
 */
public static function checkSum($iinValue)
{
    $controlDigit = self::getControlDigit($iinValue, self::$firstSequenceBitWeights);

    if ($controlDigit === 10) {
        return self::getControlDigit($iinValue, self::$secondSequenceBitWeights);
    }

    return $controlDigit;
}

/**
 * @param string $iinValue
 * @param array $sequence
 *
 * @return integer
 */
protected static function getControlDigit($iinValue, $sequence) 
{
    $sum = 0;

    for ($i = 0; $i <= 10; $i++) {
        $sum += (int) $iinValue[$i] * $sequence[$i];
    }

    return $sum % 11;
}

[YerlenZhubangaliyev]

ok looks fine

[YerlenZhubangaliyev]

done

[ankitpokhrel]

👍

[fzaninotto]

Much better!

[fzaninotto]

Thanks!

[YerlenZhubangaliyev]

Thank you very much!