This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Get currency codes from library to stay up to date #1360
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to stay up to date with changing currency codes.
Background:
In our current project, we perform validation of currency codes. In UnitTests, these codes are generated by Faker and produce randomly failing tests due to a divergence between actual currency codes and the ones that Faker produces.
This applies to the following codes, which are not considered valid by our application that uses
alcohol/iso4217
to retrieve the codes:Using the lib makes it more likely to stay up to date with the changes.
If you don't like the idea of adding that lib, please let me know. I would update the static list of currency codes to reflect the current state as well.