Add zh_TW Provider #427
Add zh_TW Provider #427
Conversation
|
Tests fail. |
| return $digits[mt_rand(0, count($digits)-1)]; | ||
| } | ||
|
|
||
| public static function randomNumber2() |
There was a problem hiding this comment.
Do you want a not null number? Then use randomDigitNotNull, or numerify with %.
|
I have patched the base Text provider and overrided only a small parts of it for zh_TW provider. Could you please have a look on it and consider merge it? thanks. |
| ), | ||
| ); | ||
|
|
||
| # Reference: http://terms.naer.edu.tw/download/287/ |
There was a problem hiding this comment.
Please use the // syntax, or better, the phpDoc syntax:
/**
* @link http://terms.naer.edu.tw/download/287/
*/
|
Most of the PR is OK, but I'm afraid the realText provider will need some more work. I suggest you split the PR in two, putting the realText stuff in a second PR. Then I'll merge the first one, and we can discuss the realText PR further. |
This reverts commit 6af3cce. Conflicts: src/Faker/Provider/Text.php
|
Okay, the realText part is removed in this PR. I'll open a new PR for that. |
|
I am expect this PR be merged. It is much helpful ! =D |
|
Much appreciated, thanks! |
|
Thanks! |
|
Why the added |
|
The romanization of the name is usually required and used for credit-card in Taiwan. |
No description provided.