This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Modify numberBetween() to be order agnostic #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
added a commit
that referenced
this pull request
Aug 26, 2015
Modify numberBetween() to be order agnostic
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, modified numberBetween() to be order agnostic (allow min/max to be supplied in either order).
I've done this as I found without this here, I had to put a lot of supporting conditional ordering code in my seeder script for a few specific usecases. This makes using it much cleaner and won't break anything that currently uses it.
(And yes, am aware of randomFloat())
Thanks!