This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
add DNI generator to spanis person #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,4 +70,12 @@ public static function suffix() | |||
| { | |||
| return static::randomElement(static::$suffix); | |||
| } | |||
|
|
|||
| public static function dni() | |||
There was a problem hiding this comment.
please add a link to the dni specification
There was a problem hiding this comment.
There was a problem hiding this comment.
Please add it as a @link annotation in the method phpDoc
|
You should add a unit test for this new formatter. |
fzaninotto
added a commit
that referenced
this pull request
Feb 23, 2016
add DNI generator to spanis person
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to generate DNI on unit tests and I use faker as data provider. I couldn't find DNI anywhere, so I implemented it