infoschema: make information_schema.columns copyable (pingcap#45552)

close pingcap#42030
fzzf678 · Nov 23, 2023 · 0e8f8cd · 0e8f8cd
1 parent 1cf2826
commit 0e8f8cd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/pkg/ddl/tests/serial/serial_test.go b/pkg/ddl/tests/serial/serial_test.go
@@ -217,6 +217,12 @@ func TestCreateTableWithLike(t *testing.T) {
 
 	tk.MustExec("drop database ctwl_db")
 	tk.MustExec("drop database ctwl_db1")
+
+	// Test information_schema.columns copiability.
+	// See https://github.com/pingcap/tidb/issues/42030.
+	tk.MustExec("use test")
+	tk.MustExec("create table cc like information_schema.columns;")
+	tk.MustExec("insert into cc select * from information_schema.columns;")
 }
 
 func TestCreateTableWithLikeAtTemporaryMode(t *testing.T) {

diff --git a/pkg/infoschema/tables.go b/pkg/infoschema/tables.go
@@ -462,7 +462,7 @@ var columnsCols = []columnInfo{
 	{name: "COLLATION_NAME", tp: mysql.TypeVarchar, size: 32},
 	{name: "COLUMN_TYPE", tp: mysql.TypeBlob, size: 196606},
 	{name: "COLUMN_KEY", tp: mysql.TypeVarchar, size: 3},
-	{name: "EXTRA", tp: mysql.TypeVarchar, size: 30},
+	{name: "EXTRA", tp: mysql.TypeVarchar, size: 45},
 	{name: "PRIVILEGES", tp: mysql.TypeVarchar, size: 80},
 	{name: "COLUMN_COMMENT", tp: mysql.TypeVarchar, size: 1024},
 	{name: "GENERATION_EXPRESSION", tp: mysql.TypeBlob, size: 589779, flag: mysql.NotNullFlag},