Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glm::mod() compilation error. #281

Closed
mackron opened this issue Nov 29, 2014 · 1 comment
Closed

glm::mod() compilation error. #281

mackron opened this issue Nov 29, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@mackron
Copy link

mackron commented Nov 29, 2014

I'm not quite sure what the intent is here, but starting on line 297 on the 0.9.6 branch, you have a glm::mod() implementation defined as

template <typename genType>
GLM_FUNC_QUALIFIER genType mod(genType x, genType y)
{
    return tvec1<genType>(x, y).x;
}

Which is causing a compilation error for me on VC12. I believe it should be

template <typename genType>
GLM_FUNC_QUALIFIER genType mod(genType x, genType y)
{
    return x - y * floor(x / y);
}
@Groovounet Groovounet added the bug label Nov 29, 2014
@Groovounet Groovounet added this to the GLM 0.9.6 milestone Nov 29, 2014
@Groovounet Groovounet self-assigned this Nov 29, 2014
@Groovounet
Copy link
Member

This issue is fixed in GLM 0.9.6 ans master branches.

Thanks for reporting,
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants