Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing -m64 for GCC disrupts testing on 32-bit systems #331

Closed
muep opened this issue Apr 26, 2015 · 1 comment
Closed

Forcing -m64 for GCC disrupts testing on 32-bit systems #331

muep opened this issue Apr 26, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@muep
Copy link

muep commented Apr 26, 2015

Is it actually necessary to have CMakeLists.txt always specify -m64 like it does here:

if(CMAKE_COMPILER_IS_GNUCXX)
    #add_definitions(-S)
    #add_definitions(-s)
    add_definitions(-m64)
    add_definitions(-O2)

    #add_definitions(-fprofile-arcs -ftest-coverage) gcov
    #ctest_enable_coverage()
endif()

I would normally expect to be able to build and run the tests on the native architecture of the host I use, without having to change the cmake setup on 32-bit hosts. This is also used in the Fedora packaging of glm, that runs the tests shipped alongside glm when packages are built.

@Groovounet Groovounet added the bug label May 1, 2015
@Groovounet Groovounet added this to the GLM 0.9.7 milestone May 1, 2015
@Groovounet Groovounet self-assigned this May 1, 2015
@Groovounet
Copy link
Member

This issue is fixed in master branch for GLM 0.9.7 release and I might back port it to GLM 0.9.6.4 if this is useful.

Thanks for contributing,
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants