Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] 64-bit integer constants on x86 ~ glm/gtc/bitfield.inl #463

Closed
MarisaLovesUsAll opened this issue Dec 16, 2015 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@MarisaLovesUsAll
Copy link

Versions: 0.9.7.1 (bitfield.inl), 0.9.5.4 (bit.inl)
Compiler: gcc 4.1 (fails both versions), gcc 4.8.3 (succeed both versions)

Tried to compile tests on x86, got this

glm/./gtx/bit.inl:551: error: integer constant is too large for 'long' type

Constants like 0xFFFF00000000FFFF is 64 bits long, which is allowed in C++11 only.
Relatively new GCC just gives a warning, but old versions of GCC can't compile it, showing an error.

Maybe adding ULL to the constants can help (0xFFFF00000000FFFFULL). Didn't test, though.

@Groovounet Groovounet added the bug label Jan 3, 2016
@Groovounet Groovounet self-assigned this Jan 3, 2016
@Groovounet
Copy link
Member

Do you have a fix suggestion?
GCC support a 64 bits extensions which is so useful GLM requires it.

GCC 4.1 is not supported anymore by GLM. GCC 4.6 generates warnings too: https://drone.io/github.com/g-truc/glm/latest

Currently GLM requires at least GCC 4.2 but I guess if there is issues with GCC 4.2, I'll rather rise the GCC version requires than hack away 64 bits support.

Thanks,
Christophe

@Groovounet Groovounet added this to the GLM 0.9.7 milestone Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants