-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize on dimensions #584
Comments
Hi, Alias templates are not supported by Visual Studio 2013 and I think it's too early to drop 2013. Actually GLM 0.9.9 is the first version that will drop Visual Studio 2010 support... So I should have said, I am considering requiring some C++11 features. Thanks, |
FYI, I got this working on Clang / GCC: johnmcfarlane#2 |
I pulled the branch into "dim" branch to run the tests. With Visual C++ it doesn't built but looking at the code it looks very promising! I'll have a closer look. |
Thanks. Surprisingly, I was able to compile on VS2013 & VS2015 with very few fixes. They are pushed: johnmcfarlane#2 |
This issue is merged in master branch for 0.9.9 release. Thanks for contributing, |
Glad to help, thanks! (I might also take a look at |
You mentioned making C++11 the minimum spec. This would make a lot of things far easier.
One missing feature which I've heard mentioned and which I've been able to implement myself is a dimension parameter.
It would be nice to replace
with:
This would help reduce a lot of duplication, notably in the heterogeneous operation change that I've part implemented.
I'm not sure that this needs
using
aliases and therefore that you'd need to drop C++03. I see that you've used nested templates (e.g.) to make the code nice and generic. It may also be possible to get around the limitations oftypedef
with inheritance, e.g.but it's hard to say without some costly experimentation. I've started experimenting in my fork with the
using
solution above and it's a big, big change!I'm sure you've thought about this feature. Is there any particular reason not to do it? Do you think it's dependent on C++11? Would you consider a PR from me if I was able to achieve it?
The text was updated successfully, but these errors were encountered: