Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packF3x9_E1x5() invalid conversion to shared exponent format #614

Closed
Jojendersie opened this issue Feb 28, 2017 · 1 comment
Closed

packF3x9_E1x5() invalid conversion to shared exponent format #614

Jojendersie opened this issue Feb 28, 2017 · 1 comment
Assignees
@Groovounet
Milestone
GLM 0.9.8

Comments

@Jojendersie
Copy link

In file glm/gtc/packing.inl line 621 a wrong constant causes invalid outputs. The problem is the 16.f which must be 15.f (Exponent bias).

Possible test: Convert a fine gray gradient into shared exponent RGB9E5 format. There will be invalid dark (near black) lines at certain gray levels.

Please also fix this in the gli library. In gli/external/glm the same bug is present. It is actually gli where I spotted the bug while converting textures.
Groovounet added a commit that referenced this issue Feb 28, 2017
@Groovounet
- Fixed packF3x9_E1x5 exponent packing #614
c6a8b44
Groovounet added a commit that referenced this issue Feb 28, 2017
@Groovounet
- Fixed packF3x9_E1x5 exponent packing #614
d53e367
@Groovounet Groovounet self-assigned this Feb 28, 2017
@Groovounet Groovounet added this to the GLM 0.9.8 milestone Feb 28, 2017
@Groovounet
Copy link
Member

This issue is now fixed in GLM 0.9.8 ans master branches.
I'll updated GLM in GLI as well.

Thanks for reporting,
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Groovounet Groovounet

Labels
None yet
Projects
None yet
Milestone
GLM 0.9.8
Development

No branches or pull requests
2 participants
@Groovounet @Jojendersie