Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible error in tdualquat comparison operator #629

Closed
dmisc opened this issue May 24, 2017 · 1 comment
Closed

Possible error in tdualquat comparison operator #629

dmisc opened this issue May 24, 2017 · 1 comment
Assignees
@Groovounet
Milestone
GLM 0.9.9

Comments

@dmisc
Copy link

dmisc commented May 24, 2017

Dual quaternion operator != implementation looks different from operator ==
return (q1.real != q2.dual) || (q1.real != q2.dual);
return (q1.real == q2.real) && (q1.dual == q2.dual);

https://github.com/g-truc/glm/blob/master/glm/gtx/dual_quaternion.inl#L220
@Groovounet Groovounet self-assigned this Jun 4, 2017
@Groovounet Groovounet added this to the GLM 0.9.9 milestone Jun 4, 2017
Groovounet added a commit that referenced this issue Jun 4, 2017
@Groovounet
Fixed dual quaternion != operator #629
2834d73
@Groovounet
Copy link
Member

This issue is fixed in master branch for GLM 0.9.9 release. Thanks for contributing!
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Groovounet Groovounet

Labels
None yet
Projects
None yet
Milestone
GLM 0.9.9
Development

No branches or pull requests
2 participants
@Groovounet @dmisc