Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acsch incorrectly defined #698

Closed
Zuzu-Typ opened this issue Nov 12, 2017 · 1 comment
Closed

acsch incorrectly defined #698

Zuzu-Typ opened this issue Nov 12, 2017 · 1 comment
Assignees
Milestone

Comments

@Zuzu-Typ
Copy link

So when working on a Python redistribution of GLM, I noticed an accidental recursion in reciprocal.inl.

[...]
// acsch
template<typename genType>
GLM_FUNC_QUALIFIER genType acsch(genType x)
{
	GLM_STATIC_ASSERT(std::numeric_limits<genType>::is_iec559, "'acsch' only accept floating-point values");
	return acsch(genType(1) / x);
}
[...]

it should be

return asinh(genType(1) / x);
Groovounet added a commit that referenced this issue Nov 22, 2017
@Groovounet Groovounet self-assigned this Nov 22, 2017
@Groovounet Groovounet added this to the GLM 0.9.9 milestone Nov 22, 2017
@Groovounet
Copy link
Member

This issue is fixed in master branch for GLM 0.9.9 release.

Thanks for reporting,
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants