Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require integer type for bitCount and bitfieldReverse #893

Closed
Zuzu-Typ opened this issue Apr 8, 2019 · 1 comment
Closed

require integer type for bitCount and bitfieldReverse #893

Zuzu-Typ opened this issue Apr 8, 2019 · 1 comment
Assignees
@Groovounet
Labels
core enhancement
Milestone
GLM 0.9.9

Comments

@Zuzu-Typ
Copy link

Zuzu-Typ commented Apr 8, 2019

bitCount() and bitfieldReverse() require integer inputs, so a check should be performed wether they are or not.

Additionally, bitfieldReverse() throws warning C4309 in Visual C++ if typename T (the argument's underlying type) isn't unsigned long long or u64vec respectively, because unsigned long long constants are cast to T.
Since the casting is intentional, you might want to silence the warning for this part of the code.
@Zuzu-Typ Zuzu-Typ mentioned this issue May 30, 2019
Open
@Groovounet Groovounet self-assigned this Sep 7, 2019
Groovounet added a commit that referenced this issue Sep 7, 2019
@Groovounet
Added missing genType check for bitCount and bitfieldReverse #893
f4b3fc7
Groovounet added a commit that referenced this issue Sep 7, 2019
@Groovounet
Added missing genType check for bitCount and bitfieldReverse #893
b8e5f55
@Groovounet Groovounet added this to the GLM 0.9.9 milestone Sep 7, 2019
@Groovounet Groovounet added the core label Sep 7, 2019
@Groovounet
Copy link
Member

This issue is resolved on master branch for GLM 0.9.9.6 release.

Thanks for contributing,
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Groovounet Groovounet

Labels
core enhancement
Projects
None yet
Milestone
GLM 0.9.9
Development

No branches or pull requests
2 participants
@Groovounet @Zuzu-Typ