Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLM_HAS_CXX11_STL broken on Clang with Linux #926

Closed
muusbolla opened this issue Jul 19, 2019 · 1 comment
Closed

GLM_HAS_CXX11_STL broken on Clang with Linux #926

muusbolla opened this issue Jul 19, 2019 · 1 comment
Assignees
Milestone

Comments

@muusbolla
Copy link

muusbolla commented Jul 19, 2019

GLM_HAS_CXX11_STL does not work on Linux with clang. It sees that the compiler is clang, then goes inside of the elif and tests for _LIBCPP_VERSION and _MSC_VER which are not defined, then exits. This happens at line 145-147 of setup.hpp.

_LIBCPP_VERSION is not defined by clang. It is only defined when including libc++ on certain platforms so it shouldn't be checked inside of the
#elif GLM_COMPILER & GLM_COMPILER_CLANG
block. I'm not sure how this block works exactly on Windows, but on my build with -std=c++17, __cplusplus is properly defined, so just testing GLM_LANG & GLM_LANG_CXX11_FLAG is good enough. I ripped out the whole windows specific bit in my setup.hpp line 145 (version 0.9.9.5-1 Manjaro Linux AUR) and just have the following:

#elif GLM_LANG & GLM_LANG_CXX11_FLAG || defined(GLM_LANG_STL11_FORCED)
#	define GLM_HAS_CXX11_STL 1
@Groovounet Groovounet self-assigned this Sep 7, 2019
@Groovounet Groovounet added this to the GLM 0.9.9 milestone Sep 7, 2019
@Groovounet
Copy link
Member

This issue should be fixed in master branch for GLM 0.9.9.6 release.

Thanks for reporting,
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants