Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary warnings from matrix_clip_space.inl #980

Closed
crazydef opened this issue Dec 2, 2019 · 2 comments
Closed

Unnecessary warnings from matrix_clip_space.inl #980

crazydef opened this issue Dec 2, 2019 · 2 comments
Assignees
@Groovounet
Labels
bug extension
Milestone
GLM 0.9.9

Comments

@crazydef
Copy link

crazydef commented Dec 2, 2019

The if statements between lines 70 and 115(ish) in the aforementioned file generate a ton of "conditional expression is constant" warnings.

These should probably be preprocessor control statements. (#if, #elif, #else, etc.)
Groovounet pushed a commit that referenced this issue Dec 9, 2019
Fixed GLM_EXT_matrix_clip_space warnings #980
8828c3f
@Groovounet Groovounet self-assigned this Dec 9, 2019
@Groovounet Groovounet added this to the GLM 0.9.9 milestone Dec 9, 2019
@Groovounet
Copy link
Member

This issue is fixed on master branch for GLM 0.9.9.7 release.

Thanks for reporting,
Christophe

@crazydef
Copy link
Author

crazydef commented Dec 9, 2019

You even found some I missed. Nice. :)

@pmbarrett314 pmbarrett314 mentioned this issue Feb 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Groovounet Groovounet

Labels
bug extension
Projects
None yet
Milestone
GLM 0.9.9
Development

No branches or pull requests
2 participants
@Groovounet @crazydef