Specialize integer implementation of YCoCg-R to use bitshifts #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the current implementation of YCoCgR conversion is not reversible (f(g(x)) != x) for certain combinations of pixels, for example:
I've added a patch that specializes the template instantiation for integer types to use bit shifts as outlined in Eqn (8) of this paper. This fixes the situation in the assert, yet leaves floating point implementations to work as they used to.