Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed shadow warnings for vec3, vec4 and quaternions #595

Merged
merged 3 commits into from
Jan 4, 2017
Merged

Fixed shadow warnings for vec3, vec4 and quaternions #595

merged 3 commits into from
Jan 4, 2017

Conversation

mgerhardy
Copy link

No description provided.

@Groovounet
Copy link
Member

The PR looks fine and I'll look at it at some point for GLM 0.9.9. I think it would be better if it could be made more consistent across argument.

Thanks for contributing,
Christophe

@Groovounet Groovounet self-assigned this Jan 3, 2017
@Groovounet Groovounet added this to the GLM 0.9.9 milestone Jan 3, 2017
Groovounet added a commit that referenced this pull request Jan 4, 2017
@Groovounet
More consistent resolution of shadow warnings #595
eda6c93
@Groovounet Groovounet merged commit 9e45b45 into g-truc:master Jan 4, 2017
@Groovounet
Copy link
Member

This issue is fixed in GLM master branch.

Thanks for contributing,
Christophe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Groovounet Groovounet

Labels
None yet
Projects
None yet
Milestone
GLM 0.9.9
Development

Successfully merging this pull request may close these issues.
2 participants
@mgerhardy @Groovounet