Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR factorisation of matrices #654

Merged
merged 6 commits into from
Jul 7, 2017
Merged

QR factorisation of matrices #654

merged 6 commits into from
Jul 7, 2017

Conversation

unordinateur
Copy link

As discussed in issue #645, here is my code contribution to the project, for implementing QR and RQ matrices factorisation.

Here are 2 suggestions for subsequent additions/modification:

  • I implemented two helper functions, flipup and fliplr. They should be moved elsewhere, in another module, because they are of vastly more general usage than my factorisation functions.
  • I implemented only QR and RQ factorisation of matrices, but many more type of matrix factorisation are possible: QL and LQ, LU and LDU, eigendecomposition, etc... If somebody want to implement those methods, they should!

@Groovounet Groovounet self-assigned this Jul 7, 2017
@Groovounet Groovounet added this to the GLM 0.9.9 milestone Jul 7, 2017
@Groovounet Groovounet merged commit 1ce38b4 into g-truc:master Jul 7, 2017
@Groovounet
Copy link
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants