Modifications suggested by conan team #662
Conversation
| conanbuildinfo.cmake | ||
| !FindGLM.cmake |
There was a problem hiding this comment.
Why do you need to explicitly include FindGLM? Does it match some other ignore pattern?
There was a problem hiding this comment.
There is an exclusion of all .cmake files in the .gitignore of the top level directory:
https://github.com/g-truc/glm/blob/master/.gitignore
| TARGET_COMPILE_DEFINITIONS(testGlm PUBLIC "${CONAN_DEFINES}") | ||
| TARGET_LINK_LIBRARIES(testGlm PUBLIC "${CONAN_LIBS}") | ||
| SET_TARGET_PROPERTIES(testGlm PROPERTIES LINK_FLAGS "${CONAN_EXE_LINKER_FLAGS}") | ||
|
|
There was a problem hiding this comment.
Good point. Header only doesnt need further config
There was a problem hiding this comment.
Thanks for the feedback. I've also updated the readme: https://github.com/dimi309/glm/blob/master/util/conan-package/README.md
I don't see how the conan packaging configuration could possibly affect the build. It is located within its own directory and, since it requires no compilation, it doesn't even have a travis or appveyor setup.
|
I see travis tests broken, but master branch seems also broken, I think it is not because of this PR. |
The glm package has now been accepted to the conan-center repository:
https://bintray.com/conan/conan-center
At the same time, the conan team has suggested some modifications to the packaging configuration, which I am introducing with this pull request.