Fix warnings and package dependencies #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2017 23:15
Newest compilers complain about constructor initialization order.
mikepurvis
reviewed
Jan 25, 2017
| @@ -3,6 +3,7 @@ add_executable(${PROJECT_NAME}_node driver controller channel) | |||
| add_dependencies(${PROJECT_NAME}_node ${PROJECT_NAME}_script roboteq_msgs_generate_messages_cpp) | |||
| target_link_libraries(${PROJECT_NAME}_node ${PROJECT_NAME}_script ${catkin_LIBRARIES}) | |||
| set_target_properties(${PROJECT_NAME}_node PROPERTIES OUTPUT_NAME driver_node PREFIX "") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wno-unused-parameter") | |||
There was a problem hiding this comment.
Would prefer set_directory_properties, see:
https://github.com/ros/ros_comm/search?q=set_directory_properties&type=Code
Otherwise this all LGTM.
mikepurvis
reviewed
Feb 1, 2017
| @@ -1,7 +1,7 @@ | |||
| cmake_minimum_required(VERSION 2.8.3) | |||
| project(roboteq_driver) | |||
|
|
|||
| find_package(catkin REQUIRED COMPONENTS roboteq_msgs roscpp serial) | |||
| find_package(catkin REQUIRED COMPONENTS roscpp serial message_generation std_msgs roboteq_msgs) | |||
There was a problem hiding this comment.
Why are these necessary here? This package doesn't generate any messages, and roboteq_msgs contains the dependency on the std_msgs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make the package build warning-free on gcc-5.4.0 with -Wall and -Wextra flags enabled. The missing dependencies must be corrected in order to use this package in the Yocto build system.