Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lack of documentation/demonstration #2

Closed
ibes opened this issue Jun 18, 2013 · 6 comments
Closed

lack of documentation/demonstration #2

ibes opened this issue Jun 18, 2013 · 6 comments

Comments

@ibes
Copy link

ibes commented Jun 18, 2013

Hi,

I would like to try your datepicker, but it doesn't work out of the box for me.
My I don't use it right. A little more dokumetation or a demo on fiddler or plunker may help.

You've did a bower package and the module ist on ngmodules so I guess it is ready for use.

Which browsers do you support?

@g00fy-
Copy link
Owner

g00fy- commented Jun 18, 2013

True, I'll have to create some docs.
Currently this module requires:

  • angular 1.1.4 or 1.1.5
  • jquery (or your own implementation of postion() on top of jQuery Lite

I have a working demo here:
http://plnkr.co/edit/ZaYVlB3NHf0ONK4e4zXT?p=preview

@ibes
Copy link
Author

ibes commented Jun 18, 2013

Looking so nice and useful - we unfortunately use angular 1.0.7 and this breaks it.
What functions do you use and do you guess it would be possible (for example for me) to build a version that works with 1.0.7?

Would be nice to have the requirements and the demo in the readme-file. Please continue working on your project - in my opinion it's the best solution out there (spent a day searching...)

@ibes
Copy link
Author

ibes commented Jun 18, 2013

...and maybe there is a way to remove the console logs before deploy ;)

@g00fy-
Copy link
Owner

g00fy- commented Jun 18, 2013

thanks for your feedback ibes.
AFAIR , 1.1.4 supports the optional reference binding =? which is used for date-range-picker start and end options.
This project is in its very early stage - I didn't even had time to write tests, but I will definitely continue working on it.

g00fy- added a commit that referenced this issue Jun 18, 2013
…equired)

removed console.logs
reformatted index.html
updated bower dependencies (angular-unstable)
updated README #2
g00fy- added a commit that referenced this issue Jun 18, 2013
…equired)

removed console.logs
reformatted index.html
updated bower dependencies (angular-unstable)
updated README #2
@ibes
Copy link
Author

ibes commented Jun 18, 2013

Thanks for the hint -> I will try to get it running with angular 1.0.7 because we don't need the date-range-picker. Maybe it works well enough.

As I have to support IE8: the function "indexOf" is not supported in IE8 - so browser requirements are at least IE9 (could be fixed with underscore.js, jquery inArray or implement it if it is needed (http://stackoverflow.com/questions/1744310/how-to-fix-array-indexof-in-javascript-for-ie-browsers)

Don't know if the rest works in IE8 and just in case you care (or want to deliver another version with wider browser support).

@g00fy-
Copy link
Owner

g00fy- commented Jun 18, 2013

As for IE8 there are already lots of shims that you can use like kris kowal's https://github.com/kriskowal/es5-shim
I will be able to tell what is the compatibility level after I finish writing tests. Then we will know, but I think that if you will provide appropriate shims, for ES5 and CSS3 then there should be no problem

@ibes ibes closed this as completed Sep 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants