Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed lodash dependancy #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed lodash dependancy #175

wants to merge 2 commits into from

Conversation

OlegKonyk
Copy link

issue #174

@OlegKonyk OlegKonyk mentioned this pull request Oct 14, 2015
Open
@th0th
Copy link

th0th commented Oct 14, 2015

Should we delete lodash from dependencies list in bower.json?

@OlegKonyk
Copy link
Author

sorry, missed that, we definitely should.
By the way I did not have chance to test that callback function (introduced in previous version) if it is working as expected...

@eralha
Copy link
Collaborator

eralha commented Oct 14, 2015

is this tested?

@OlegKonyk
Copy link
Author

Made some changes.
Tested. Callback works as expected.

@lcustodio
Copy link

👍

Lodash is out since version v1.0.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OlegKonyk @th0th @eralha @lcustodio