Fix some minor issues #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CSS rule which was causing an issue was removed. * Refactored duplicate code which checks if an event is targeted at a picker into a utility function. * Ranger picker element generation simplified.
Add picker ID to range to demonstrate updates of max / min views.
1. Demo now shows min / max validation in form. 2. Shortened some texts for readability. 3. Updated angular version.
Conflicts: app/index.html
* When a min/max date value is provided to the input that isn't a valid moment, the validation will mark any dates as valid.
Data changes from outside the directive are now caught, and the picker max/min dates are updated accordingly.
Last version was autoformatted
|
Can you please change the bower and project version in bower.json and package.json? change it to 2.0.1, this will enable bower users to update their code :). many thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues:
minDate/maxDateprovided to theinputelement was not a valid moment object, the validation function would throw an exception.minDate/maxDateare not moments (ie, validation is disabled).date-rangedirective did not watch for data changes originating from outside the directive. This has been resolved.date-rangedirective. This directive therefore used local dates.