-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add edit_url
and layers_url
attribute into initial client API response (ref: group-project-map-config
)
#706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raruto
changed the title
Add
Add Jan 9, 2024
edit_url
attribute into intial client API response (ref: group-project-map-config
)edit_url
attribute into initial client API response (ref: group-project-map-config
)
Raruto
changed the title
Add
Add Jan 9, 2024
edit_url
attribute into initial client API response (ref: group-project-map-config
)edit_url
and layers_url
attribute into initial client API response (ref: group-project-map-config
)
Raruto
commented
Jan 9, 2024
Comment on lines
+602
to
+615
# add edit url if user has grant | ||
if self.request.user.has_perm('qdjango.change_project', instance): | ||
ret['edit_url'] = reverse('qdjango-project-update', kwargs={ | ||
'group_slug': instance.group.slug, | ||
'slug': instance.slug | ||
}) | ||
|
||
# add layers url if user has grant | ||
if self.request.user.has_perm('qdjango.change_project', instance): | ||
ret['layers_url'] = reverse('qdjango-project-layers-list', kwargs={ | ||
'group_slug': instance.group.slug, | ||
'project_slug': instance.slug | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wlorenzetti @volterra79 if you have better property names, just say...
wlorenzetti
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See: Link to the edit project page g3w-client#391
improve #503 without requiring client to perform a subsequent to another API endpoint to get the
edit_url
of current project (ie: throughtabout-project-by-group-api-list
you can actually gets the edit_url of all projects within the same group, somewhat resource expensive.. ⌛)Sample Response
Related to: g3w-suite/g3w-client#392