Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔙 from #756 - 🐛 Fix session filter feature by selection fo PostgreSql layers #757

Merged
merged 1 commit into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion g3w-admin/qdjango/models/filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@
from django.utils.crypto import salted_hmac
from model_utils.models import TimeStampedModel
from usersmanage.models import User
from core.utils.qgisapi import get_layer_fids_from_server_fids
from .projects import Layer
from datetime import datetime
import time
import six
import base64
import logging
import re


logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -80,7 +82,17 @@ def get_expr_for_token(cls, token, layer):
f"More than one token or more expressions for this layer '{layer.qgs_layer_id}' exist: skipping filtering!")
return ""
else:
return stf_layers[0].qgs_expr

qgs_expr = stf_layers[0].qgs_expr
ids = re.findall(r'\((.*?)\)', stf_layers[0].qgs_expr)

# Check for `postgres` layer and qgis expression template '$id IN (...)'
if layer.layer_type == 'postgres' and len(ids) == 1:
fids = ids[0].split(',')
fids = get_layer_fids_from_server_fids(map(str, fids), layer.qgis_layer)
return f"$id IN ({','.join(map(str, fids))})"
else:
return qgs_expr

class Meta:
app_label = 'qdjango'
Expand Down
10 changes: 5 additions & 5 deletions g3w-admin/qdjango/tests/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,7 @@ def test_tokenfilter_mode_api(self):

self.assertEqual(resp['data'], {
'layer': cities.qgs_layer_id,
'qgs_expression': '$id NOT IN (9,8,6,0)',
'qgs_expression': '$id NOT IN (6,8,9,0)',
'name': 'filter 1 layer cities',
'fid': 1,
'state': 'created'
Expand All @@ -1154,7 +1154,7 @@ def test_tokenfilter_mode_api(self):

self.assertEqual(resp['data'], {
'layer': cities.qgs_layer_id,
'qgs_expression': '$id NOT IN (9,8,6,0)',
'qgs_expression': '$id NOT IN (6,8,9,0)',
'name': 'filter 1 layer cities',
'fid': 1,
'state': 'updated'
Expand All @@ -1180,7 +1180,7 @@ def test_tokenfilter_mode_api(self):

self.assertEqual(resp['data'], {
'layer': cities.qgs_layer_id,
'qgs_expression': '$id NOT IN (9,8,6,0) AND $id NOT IN (2,1)',
'qgs_expression': '$id NOT IN (6,8,9,0) AND $id NOT IN (1,2)',
'name': 'filter 2 layer cities',
'fid': 2,
'state': 'created'
Expand Down Expand Up @@ -1213,7 +1213,7 @@ def test_tokenfilter_mode_api(self):

# Check inside the current fitlertoken
token = sf.token
self.assertEqual(sf.stf_layers.all()[0].qgs_expr, '$id NOT IN (9,8,6,0)')
self.assertEqual(sf.stf_layers.all()[0].qgs_expr, '$id NOT IN (6,8,9,0)')

# Delete fitler token and apply again to check for new fitler token value
SessionTokenFilter.objects.all().delete()
Expand All @@ -1226,7 +1226,7 @@ def test_tokenfilter_mode_api(self):
}, logout=False).content)
sf = SessionTokenFilter.objects.all()[0]
self.assertFalse(token == sf.token)
self.assertEqual(sf.stf_layers.all()[0].qgs_expr, '$id NOT IN (9,8,6,0)')
self.assertEqual(sf.stf_layers.all()[0].qgs_expr, '$id NOT IN (6,8,9,0)')

# Filter for layer check /api/config REST API:
resp = json.loads(self._testApiCall('group-project-map-config',
Expand Down
12 changes: 0 additions & 12 deletions g3w-admin/qdjango/vector.py
Original file line number Diff line number Diff line change
Expand Up @@ -417,18 +417,6 @@ def _get_sessiontokenfilter():
fidsin = request_data.get('fidsin')
fidsout = request_data.get('fidsout')

# Get layer fids from server fids
if fidsin:
fidsin = get_layer_fids_from_server_fids([str(fid) for fid in fidsin.split(',')],
self.metadata_layer.qgis_layer)
fidsin.reverse()
fidsin = ",".join(map(str, fidsin))
if fidsout:
fidsout = get_layer_fids_from_server_fids([str(fid) for fid in fidsout.split(',')],
self.metadata_layer.qgis_layer)
fidsout.reverse()
fidsout = ",".join(map(str, fidsout))

token_data = {}

def _create_qgs_expr(s, fidsin=None, fidsout=None):
Expand Down