Internal components refactor [g3w-client #574] #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raruto
commented
Mar 25, 2024
| 'type': ({ | ||
| 'autocompletebox': 'autocompletefield', | ||
| 'selectbox': 'selectfield' | ||
| }).get(field.get('widgettype'), field['input'].get('type')), |
There was a problem hiding this comment.
@wlorenzetti the numberfield type should also be returned in here (currently not implement in v3.7 response):
OK: "Volume greater than" appears as number field
KO: "Volume greater than" appears as text field
Sample config: "Type and volume"
Raruto
commented
Mar 26, 2024
1 task
…2abbc82c43e64758b663f50d8eee
…029e1d28cbb06323f425a1394061
…c37fa834d1e591541694e4304ed7
|
@leolami g3w-suite/g3w-client@f99134b takes care of empty query result for: Before
After
Unsearchable layer(s)I think some check is missing on the server side. From what I see, some other layers shouldn't be searchable either (unless relationships could break that option?):
|
|
@wlorenzetti still waiting for your review → merge 😉 |
wlorenzetti
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
G3WObject,PanelandComponentclasses g3w-client#574WidgetSerializerand/api/config/<gid>/qdjango/<pid>)G3W_CLIENT_SEARCH_ENDPOINT = 'ows'(until removal, the new default is:'api')