Fix map alias url #844
Merged
Fix map alias url #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raruto
reviewed
May 10, 2024
Comment on lines
+85
to
+91
| try: | ||
| group = self.project.group | ||
| except: | ||
| group = get_object_or_404(Group, slug=kwargs['group_slug']) | ||
|
|
||
| groupSerializer = GroupSerializer( | ||
| getattr(self.project, 'group', get_object_or_404(Group, slug=kwargs['group_slug'])), | ||
| group, |
There was a problem hiding this comment.
@wlorenzetti I tried it like the following and it works the same:
# group serializer
# try:
# group = self.project.group
# except:
# group = get_object_or_404(Group, slug=kwargs['group_slug'])
groupSerializer = GroupSerializer(
self.project.group,
projectId=str(self.project.pk),
projectType=kwargs['project_type'],
request=self.request
)Just to know, the CU plugin is a special case of projects without a group? ref: e634b10
There was a problem hiding this comment.
@Raruto do you mean CDU?
There was a problem hiding this comment.
@wlorenzetti maybe it's a mispelling, I find it through git blame: e634b10 (commited on Nov 27, 2017)
Raruto
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by: #836
Closes: #843
Motivation
Checking the getattr statement before the default value that in the case of url alias return a 404.