Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field filter for comma separated values ​​requests (e.g. "field" IN('value1', 'value2')). #876

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

wlorenzetti
Copy link
Member

Closes: #874

@wlorenzetti wlorenzetti added bug Something isn't working backport to v.3.7.x labels Jun 10, 2024
@wlorenzetti wlorenzetti added this to the v3.8 milestone Jun 10, 2024
@wlorenzetti wlorenzetti requested a review from Raruto June 10, 2024 13:30
@wlorenzetti wlorenzetti self-assigned this Jun 10, 2024
@Raruto Raruto changed the title 'Comma' elements inside value of a field filter. Fix field filter for comma separated values ​​requests (e.g. "field" IN('value1', 'value2')). Jun 10, 2024
@Raruto Raruto marked this pull request as ready for review June 10, 2024 14:43
@wlorenzetti wlorenzetti merged commit e78c93a into dev Jun 10, 2024
6 checks passed
@wlorenzetti wlorenzetti deleted the split_by_comma branch June 10, 2024 14:55
Copy link

The backport to v.3.7.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v.3.7.x v.3.7.x
# Navigate to the new working tree
cd .worktrees/backport-v.3.7.x
# Create a new branch
git switch --create backport-876-to-v.3.7.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e78c93aa959266343d538c35a6d354ec1fce7305
# Push it to GitHub
git push --set-upstream origin backport-876-to-v.3.7.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v.3.7.x

Then, create a pull request where the base branch is v.3.7.x and the compare/head branch is backport-876-to-v.3.7.x.

wlorenzetti added a commit that referenced this pull request Jun 11, 2024
Co-authored-by: wlorenzetti <lorenzett@gis3w.it>
(cherry picked from commit e78c93a)
wlorenzetti added a commit that referenced this pull request Jun 11, 2024
Co-authored-by: wlorenzetti <lorenzett@gis3w.it>
(cherry picked from commit e78c93a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to v.3.7.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal Server Error: when using QueryBuilder IN / NOT IN clauses
2 participants