adding a session refershing object #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
session/refresh.go
Outdated
| func (s *Refresher) Shutdown() { | ||
| close(s.stop) | ||
| } | ||
| func (s *Refresher) refresh() error { |
There was a problem hiding this comment.
do you want these receiver variables to be r instead?
session/refresh.go
Outdated
| // OpenRefresh will open the first session and set up a re-occuring refresh of the session token. | ||
| func OpenRefresh(config sfdc.Configuration, refershTime int) (*Refresher, error) { | ||
| if refershTime <= 0 { | ||
| return nil, errors.New("session refresh: refresh time can not be less than zero") |
There was a problem hiding this comment.
this error message technically doesn't align with the logic - is < 1 sufficient?
session/refresh.go
Outdated
| time.Sleep(sleep) | ||
| if err := refresher.refresh(); err != nil { | ||
| refresher.err = err | ||
| sleep = 5 * time.Second |
There was a problem hiding this comment.
not sure I follow the 5 second hard-code here, can you explain?
There was a problem hiding this comment.
that was just a magic number, any suggestions?
There was a problem hiding this comment.
tried to handle with a user supplied struct (also added a default one because I am nice)
added 2 commits
August 24, 2019 17:36
…al and error refresh periods
Guitarbum722
approved these changes
Aug 25, 2019
|
@g8rswimmer @Guitarbum722 do you guys still aim to merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Guitarbum722 please look this over before I add the unit tests