This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
Added comments clarifying how to handle coordinates in circular genomes #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good clarification I think: +1 |
|
+1 |
|
+1 |
cassiedoll
added a commit
that referenced
this pull request
Oct 2, 2014
Added comments clarifying how to handle coordinates in circular genomes
dcolligan
pushed a commit
to dcolligan/ga4gh-schemas
that referenced
this pull request
Jul 20, 2016
Check that Variant in the VariantAnnotation record exists
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #132 as suggested by @richarddurbin
"...not allow negative coordinates..."
"...handle circular genomes in the graph framework, with subsequences spanning the join being made of two segments, one on each side of the join"
It simply adds a few comments. There are no changes in records or other definitions involved.