This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
Add Auth0 docs and ~b64decoding #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david4096
force-pushed
the
1565_auth0
branch
2 times, most recently
from
e253983 to
e4cf993
Compare
With external links to images Close ga4gh#1565
Codecov Report
@@ Coverage Diff @@
## master #1620 +/- ##
==========================================
- Coverage 86.65% 86.65% -0.01%
==========================================
Files 33 33
Lines 7471 7469 -2
Branches 926 926
==========================================
- Hits 6474 6472 -2
Misses 805 805
Partials 192 192
Continue to review full report at Codecov.
|
|
+1, and merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you SOOO much @Welliton309 for writing these docs. The community could really benefit from easier authentication/authorization solutions!
This PR fixes a problem found in #1565 that Auth0 changed the formatting of their client secrets (no longer b64 encoded). This PR fixes that to support all future Auth0 clients.
The links to the images are hosted by github's cache, which is probably not a great solution and they should be checked in.
TODO
Move images to static directory.