Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fi build and readme #220

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Fi build and readme #220

merged 2 commits into from
Oct 20, 2024

Conversation

vsmalladi
Copy link
Contributor

  • Fix some of the description in readme and tags.

  • Fix build to run based on requirements of plugins

* Fix some of the description in readme and tags.

* Fix build to run based on requirements of plugins
@vsmalladi vsmalladi requested a review from uniqueg October 18, 2024 21:16
Copy link
Contributor

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly, but there's one section that seems to need some cleanup.

README.md Outdated
We work with platform development partners and industry leaders to develop standards that will facilitate
interoperability.

Cloud Work Stream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not mistaken, it looks like we're gonna have two sections with the same name. If so, please merge into a single section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uniqueg fixed

Copy link
Contributor

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vsmalladi vsmalladi merged commit 4362315 into ga4gh:develop Oct 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants