Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small comment round up #239

Merged
merged 10 commits into from
Apr 5, 2023
Merged

Small comment round up #239

merged 10 commits into from
Apr 5, 2023

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Feb 22, 2023

A couple small additions from the backlog to exercise the build fixes in #238

The actual changes are the commits from 6b0600d onwards

  • Adds tag-based search, this was feedback from a TRS update. The idea being that we could add tag-based search. As a request, this would look like https://ga4gh.github.io/ga4gh/trs/v2/tools?tags=category1,category2,category3

  • Add a tool version specific description

@denis-yuen denis-yuen self-assigned this Feb 22, 2023
@denis-yuen denis-yuen marked this pull request as ready for review February 22, 2023 20:41
Copy link
Contributor

@coverbeck coverbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With comments on related PR

Copy link
Collaborator

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @denis-yuen - great update. I added quite some comments to the README.md, maybe you will find them useful. If not, just ignore :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@denis-yuen
Copy link
Member Author

Thanks @denis-yuen - great update. I added quite some comments to the README.md, maybe you will find them useful. If not, just ignore :)

Ended up addressing these in #238 so that documentation and process updates remain there (while the two new openapi changes remain here)

@denis-yuen denis-yuen merged commit 1dd4bf8 into develop Apr 5, 2023
@denis-yuen denis-yuen deleted the small_comment_round_up branch April 5, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants