Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GA4GH Serialize / Digest behavior for RLEs #337

Closed
ahwagner opened this issue Jan 30, 2024 · 0 comments
Closed

Fix GA4GH Serialize / Digest behavior for RLEs #337

ahwagner opened this issue Jan 30, 2024 · 0 comments
Assignees
@theferrit32
Labels
2.0-alpha Issues related to VRS 2.0-alpha branch bug Something isn't working

Comments

@ahwagner
Copy link
Member

Reference Length Expressions should not include sequence attribute when serialized (schema); this is redundant information.
@ahwagner ahwagner added bug Something isn't working 2.0-alpha Issues related to VRS 2.0-alpha branch labels Jan 30, 2024
@theferrit32 theferrit32 self-assigned this Feb 1, 2024
This was referenced Feb 6, 2024
Merged
Closed
ahwagner added a commit that referenced this issue Feb 6, 2024
@ahwagner @theferrit32
Issue #334: Normalization (#337)
253b10c 
* add normalization example to test notebook

* update notebook metadata

* a few simple behavior tests

* Add keys to ReferenceLengthExpression and LiteralSequenceExpression

* Make LiteralSequenceExpression not-identifiable

* remove unnecessary / unused code

* addresses #338 (comment)

* Fix ReferenceLengthExpression tests in test_allele_translator

* linewise diff for test_annotate_vcf_grch38_noattrs

* Update test_vcf_expected_output_no_vrs_attrs.vcf.gz ReferenceLengthExpression

* Fix test_annotate_vcf_grch38_attrs

* Fix test_annotate_vcf_grch38_attrs_altsonly

---------

Co-authored-by: Kyle Ferriter <kferrite@broadinstitute.org>
@ahwagner ahwagner closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theferrit32 theferrit32

Labels
2.0-alpha Issues related to VRS 2.0-alpha branch bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahwagner @theferrit32