Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing w/ most recent urllib3 release #472

Closed
jsstevenson opened this issue Dec 23, 2024 · 1 comment · Fixed by #476
Closed

Tests failing w/ most recent urllib3 release #472

jsstevenson opened this issue Dec 23, 2024 · 1 comment · Fixed by #476
Labels
bug Something isn't working

Comments

@jsstevenson
Copy link
Contributor

The most recent urllib3 release checks for a response object property in a logging statement that the vcrpy response mock didn't declare. This makes tests fail.

@jsstevenson jsstevenson added the bug Something isn't working label Dec 23, 2024
jsstevenson added a commit that referenced this issue Dec 24, 2024
address #472 -- see explanation there. pin a non-most-recent urllib3
version until `vcrpy` merges the PR fixing compatibility.
@jsstevenson
Copy link
Contributor Author

Temp fix in #473. This issue should stay open until the VCRPy fix is merged and we can pin the release with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant