test: add coverage for dataproxy construction inputs #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsstevenson
commented
Feb 6, 2025
•
jsstevenson
commented
- check invalid inputs
- ensure env var works
korikuzma
reviewed
Feb 6, 2025
tests/extras/test_dataproxy.py
Outdated
| @@ -20,3 +24,24 @@ def test_data_proxies(dp, request): | |||
| "ga4gh:SQ.v_QTc1p-MUYdgrRv4LMT6ByXIOsdw3C_", start=0, end=50 | |||
| ) | |||
| assert seq == "CCTCGCCTCCGTTACAACGGCCTACGGTGCTGGAGGATCCTTCTGCGCAC" | |||
|
|
|||
|
|
|||
| def test_invalid_data_proxy_uri(): | |||
There was a problem hiding this comment.
Do we need to test if uri is none?
jsstevenson
changed the title
korikuzma
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.